Skip to content

fix(user_auth_methods): Handle email domains not having any auth methods in terminate auth select #10733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ThisIsMani wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(user_auth_methods): Handle email domains not having any auth methods in terminate auth select #10733

ThisIsMani wants to merge 2 commits into from

Conversation

@ThisIsMani
Copy link
Contributor

@ThisIsMani ThisIsMani commented Dec 18, 2025 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added a check to see if the auth methods list of the email domain of the user is empty.

If it is empty, then we will allow the user to continue with the flow.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Closes juspay/hyperswitch-control-center#4004

How did you test it?

curl 'http://localhost:9000/api/user/auth/select' \
  -H 'authorization: Bearer JWT' \
  --data-raw '{"id":"bcc53b5e-d97a-4249-855d-acf594755e1b"}'

Above API should give 200 OK in case of Okta setup without any email domain.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@ThisIsMani ThisIsMani requested a review from a team as a code owner December 18, 2025 16:14
@semanticdiff-com
Copy link

semanticdiff-com bot commented Dec 18, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/core/user.rs  0% smaller

@ThisIsMani ThisIsMani marked this pull request as draft December 18, 2025 16:14
@ThisIsMani ThisIsMani self-assigned this Dec 18, 2025
@ThisIsMani ThisIsMani added C-bug Category: Bug A-users Area: Users labels Dec 18, 2025
@ThisIsMani ThisIsMani marked this pull request as ready for review December 18, 2025 16:20
@codecov
Copy link

codecov bot commented Dec 18, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@f8fa541). Learn more about missing BASE report.

Files with missing lines Patch % Lines
crates/router/src/core/user.rs 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10733   +/-   ##
=======================================
  Coverage        ?    6.40%           
=======================================
  Files           ?     1263           
  Lines           ?   317070           
  Branches        ?        0           
=======================================
  Hits            ?    20303           
  Misses          ?   296767           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prajwalnl prajwalnl prajwalnl approved these changes

@Riddhiagrawal001 Riddhiagrawal001 Awaiting requested review from Riddhiagrawal001

@apoorvdixit88 apoorvdixit88 Awaiting requested review from apoorvdixit88

@racnan racnan Awaiting requested review from racnan

At least 2 approving reviews are required to merge this pull request.

Assignees

@ThisIsMani ThisIsMani

Labels

A-users Area: Users C-bug Category: Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(user_auth): Accept invite is throwing 4xx when no email domains are configured

3 participants

@ThisIsMani @prajwalnl